Fix the 'set_device_id_for_pushers_txn' background update. (matrix-or…

…g#15391) Refer to the correct field from the response when updating the background update progress.
realtyem · Apr 12, 2023 · 4550c86 · 4550c86
1 parent c3fab6a
commit 4550c86
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/15391.bugfix b/changelog.d/15391.bugfix
@@ -0,0 +1 @@
+Fix the `set_device_id_for_pushers_txn` background update crash.
diff --git a/synapse/storage/databases/main/pusher.py b/synapse/storage/databases/main/pusher.py
@@ -562,7 +562,7 @@ def set_device_id_for_pushers_txn(txn: LoggingTransaction) -> int:
             )
 
             self.db_pool.updates._background_update_progress_txn(
-                txn, "set_device_id_for_pushers", {"pusher_id": rows[-1]["id"]}
+                txn, "set_device_id_for_pushers", {"pusher_id": rows[-1]["pusher_id"]}
             )
 
             return len(rows)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix the `set_device_id_for_pushers_txn` background update crash.