Furthering the work to use asyncio in the forking launcher #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k with existing mods)
…SE_EXPERIMENTAL_FORKING_LAUNCHER in decision. Use a different ENV variable in the forking launcher so they don't clash with the variable in __init__.py. Switch out asyncio.get_event_loop() for asyncio.new_event_loop(), as the former is depreciated in newer versions of Python. Also switch out pop() for get(), as there is no reason to remove it from the environment now(plus, wouldn't this remove it so it's not evaluated in the for loop at the bottom of main() after the database prep stage?)
realtyem
force-pushed
the
asyncio-uvloop
branch
from
a3b867d
to
28392e9
Compare
realtyem
force-pushed
the
unraid_develop
branch
3 times, most recently
from
bee4a8c
to
09d98ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit merges in Quentin's work from 14099.
Second commit modifies it to work with the forking launcher.