Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune-gen does not support non-deterministic mode #365

Closed
emillon opened this issue Jan 20, 2022 · 1 comment · Fixed by #366
Closed

dune-gen does not support non-deterministic mode #365

emillon opened this issue Jan 20, 2022 · 1 comment · Fixed by #366

Comments

@emillon
Copy link
Contributor

emillon commented Jan 20, 2022

Hi,

It seems that dune-gen (used by stanza 0.2) does not support setting non-deterministic mode:

mdx/bin/dune_gen.ml

Lines 35 to 41 in 4942357

line " run_exn ~packages ~predicates ~prelude_str:[]";
line " ~non_deterministic:false";
line " ~silent_eval:false ~record_backtrace:false";
line " ~syntax:None ~silent:false";
line " ~verbose_findlib:false ~section:None";
line " ~root:None ~force_output:false";
line " ~output:(Some `Stdout)";

If we want MDX_RUN_NON_DETERMINISTIC=1 dune runtest to work, this needs be supported and dune to be adjusted so that it knows about the envvar dependency.
@Leonidas-from-XIV
Copy link
Collaborator

Thanks for the report and the debugging. From the MDX side this should be quite easy to fix.

Does dune pass all the environment options as-is to the binary produced by dune-gen? Or are there other adjustments that are necessary to do?

@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Jan 27, 2022
Merged
@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Jan 28, 2022
Merged
Leonidas-from-XIV added a commit to Leonidas-from-XIV/opam-repository that referenced this issue Jan 28, 2022
@Leonidas-from-XIV
[new release] mdx (2.1.0)
e5c62bd 
CHANGES:

#### Added

- Add support for adding language tags and metadata labels in `mli` files.
  (realworldocaml/mdx#339, realworldocaml/mdx#357, @Julow, @Leonidas-from-XIV)
- Add support for running non-deterministic tests in `dune` MDX 0.2 stanza by
  setting the `MDX_RUN_NON_DETERMINISTIC` environment variable. (realworldocaml/mdx#365,
  realworldocaml/mdx#366, @Leonidas-from-XIV)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow running non-deterministic MDX stanzas using dune-gen
2 participants
@Leonidas-from-XIV @emillon