-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jupyter Notebook output #124
base: main
Are you sure you want to change the base?
Conversation
Some quality of life improvements: supports Markdown sections and raw cells now |
Noticed a problem that causes divergence between mdx evaluation and Jupyter. The latter doesn't support multiple environments, so having two OCaml environments will cause them to be silently merged into one with the PR. |
Hi, should I revive this PR or is the environment issue something that will prevent it from working at all? |
I have a rebased form of this PR at CraigFe/jupyter if you do decide to go ahead with this. |
thanks, I've pushed your rebase here. @NathanReb we could go ahead with merging this; the only restriction it would be nice to have before that is to ensure that there is only one environment per notebook. |
From playing around with this PR, I noticed that it doesn't yet support file includes. I have a fairly hacky patch for that here, but it probably warrants a cleaner implementation (that doesn't just |
rebased to current trunk |
4338055
to
c29c5ba
Compare
I rebased, cleaned up and added a test |
Signed-off-by: Jon Ludlam <jon@recoil.org> Coauthored-by: Anil Madhavapeddy <anil@recoil.org>
This is a WIP; creating a PR to make it easy for @jonludlam and me to push to our forks