Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: implement list --shared argument #687

Closed
DaanRosendal opened this issue Nov 5, 2023 · 1 comment · Fixed by reanahub/docs.reana.io#190, reanahub/reana-client-go#153 or #692 · May be fixed by #713
Closed

cli: implement list --shared argument #687

DaanRosendal opened this issue Nov 5, 2023 · 1 comment · Fixed by reanahub/docs.reana.io#190, reanahub/reana-client-go#153 or #692 · May be fixed by #713

Comments

@DaanRosendal
Copy link
Member

No description provided.

@tiborsimko
Copy link
Member

(1) We have basically two options:

A. By default, we would show to Alice only her personal workflow runs, as previously. And, if Alice would like to access those workflow runs that somebody else shared with her, then she would activate a new CLI option such as --shared-by jane@example.org or a special value --shared-by anyuser.

B. By default, we would show to Alice all runs, mixing her personal work and anything else shared with her by somebody. And Alice would have to resort to using filters such as --filter shared_by=nobody to access her personal work.

Concerning that we are transitioning from a system without sharing, and considering that in typical usage scenarios the personal work of researchers "matters more", as it were, over what was shared, perhaps the first option makes more sense. We should consider also how this will be presented in the web UI, whether we shall show shared workflows by default, or in a dedicated tab.

(2) Note also that in any case, we should offer --filter shared_with=bob@example.org to search for those workflow runs that Alice herself shared with Bob. (And paying attention to special value shared_with=anybody.

(3) Whatever we choose, we should also design a nice new output columns such as:

$ reana-client list --shared-by=anyuser
NAME                                RUN_NUMBER   CREATED               STARTED               ENDED                 STATUS        SHARED_BY
worldpopulation-yadage-kubernetes   3            2023-11-05T18:42:00   2023-11-05T18:42:13   2023-11-05T18:43:12   finished      jane@example.org
root6-roofit-yadage-kubernetes      3            2023-11-05T18:41:57   2023-11-05T18:42:10   2023-11-05T18:43:26   finished      kevin@example.org
helloworld-yadage-kubernetes        3            2023-11-05T18:41:55   2023-11-05T18:42:07   2023-11-05T18:43:03   finished      laura@example.org

And, for the other sharing direction, from Alice to others, we could have:

$ reana-client list --shared-with=anyuser
NAME                                RUN_NUMBER   CREATED               STARTED               ENDED                 STATUS        SHARED_WITH
myanalysis                          3            2023-11-05T18:42:00   2023-11-05T18:42:13   2023-11-05T18:43:12   finished      bob@example.org,myresearchteam@cern.ch
myanalysis                          2            2023-11-04T18:42:00   2023-11-04T18:42:13   2023-11-04T18:43:12   finished      cecile@example.org

In the former scenario, "shared by" somebody with Alice, the output will have only one value. In the latter scenario, "shared with" can have many users, so we may need to delimit them by using commas.

DaanRosendal added a commit to DaanRosendal/docs.reana.io that referenced this issue Nov 21, 2023
Adds extra docs for `list` command to the docs for new sharing related
arguments.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-client that referenced this issue Nov 21, 2023
Adds new --shared, --shared-by, and --shared-with arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687
DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this issue Nov 21, 2023
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-client that referenced this issue Nov 21, 2023
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687
DaanRosendal added a commit to DaanRosendal/reana-server that referenced this issue Nov 21, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-server that referenced this issue Nov 21, 2023
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-workflow-controller that referenced this issue Nov 21, 2023
Adds new `shared`, `shared_with` and `shared_by` parameters to the `get_workflows` endpoint to retrieve workflows along with their sharing information.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-commons that referenced this issue Nov 21, 2023
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-workflow-controller that referenced this issue Nov 21, 2023
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-db that referenced this issue Nov 21, 2023
Adds new `include_shared_workflows` parameter to optionally retrieve
unowned workflows that are shared with the user.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-server that referenced this issue Nov 22, 2023
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-workflow-controller that referenced this issue Nov 23, 2023
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-client that referenced this issue Mar 13, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687
DaanRosendal added a commit to DaanRosendal/reana-client that referenced this issue Mar 13, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687
DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this issue Mar 13, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687
DaanRosendal added a commit to DaanRosendal/reana-client that referenced this issue Mar 13, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687
DaanRosendal added a commit to DaanRosendal/reana-server that referenced this issue Mar 20, 2024
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
@mdonadoni mdonadoni moved this to In review in Workflow-Sharing Jul 19, 2024
mdonadoni pushed a commit to mdonadoni/reana-db that referenced this issue Aug 9, 2024
Adds new `include_shared_workflows` parameter to optionally retrieve
unowned workflows that are shared with the user.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to mdonadoni/reana-db that referenced this issue Aug 9, 2024
Adds new `include_shared_workflows` parameter to optionally retrieve
unowned workflows that are shared with the user.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-db that referenced this issue Aug 20, 2024
Adds new `include_shared_workflows` parameter to optionally retrieve
unowned workflows that are shared with the user.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-db that referenced this issue Aug 20, 2024
Adds new `include_shared_workflows` parameter to optionally retrieve
unowned workflows that are shared with the user.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-server that referenced this issue Aug 20, 2024
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-workflow-controller that referenced this issue Aug 20, 2024
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this issue Aug 20, 2024
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-client that referenced this issue Aug 20, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687
mdonadoni pushed a commit to DaanRosendal/reana-client-go that referenced this issue Aug 20, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/docs.reana.io that referenced this issue Aug 20, 2024
Adds extra docs for `list` command to the docs for new sharing related
arguments.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this issue Aug 29, 2024
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-client that referenced this issue Aug 29, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687
mdonadoni pushed a commit to DaanRosendal/reana-server that referenced this issue Aug 29, 2024
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-workflow-controller that referenced this issue Aug 29, 2024
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/docs.reana.io that referenced this issue Aug 29, 2024
Adds extra docs for `list` command to the docs for new sharing related
arguments.

Closes reanahub/reana-client#687
tiborsimko pushed a commit to DaanRosendal/reana-commons that referenced this issue Sep 4, 2024
…hub#429)

Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
tiborsimko pushed a commit to DaanRosendal/reana-server that referenced this issue Sep 4, 2024
…#658)

Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
tiborsimko pushed a commit to DaanRosendal/reana-workflow-controller that referenced this issue Sep 4, 2024
…#552)

Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
tiborsimko pushed a commit to DaanRosendal/reana-client-go that referenced this issue Sep 4, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687
tiborsimko pushed a commit to DaanRosendal/reana-client-go that referenced this issue Sep 4, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687
tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this issue Sep 4, 2024
Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687
tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this issue Sep 4, 2024
…nahub#692)

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687
tiborsimko pushed a commit to DaanRosendal/docs.reana.io that referenced this issue Sep 4, 2024
…b#190)

Adds extra docs for `list` command to the docs for new sharing related
arguments.

Closes reanahub/reana-client#687
tiborsimko pushed a commit to DaanRosendal/docs.reana.io that referenced this issue Sep 4, 2024
…b#190)

Adds extra docs for `list` command to the docs for new sharing related
arguments.

Closes reanahub/reana-client#687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment