Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pulp<2.8.0 #707

Closed
wants to merge 1 commit into from
Closed

Conversation

clelange
Copy link
Contributor

Here is a quick fix for #706.

Closes #706

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (783c17a) 58.62% compared to head (8fa561d) 58.62%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   58.62%   58.62%           
=======================================
  Files          24       24           
  Lines        2393     2393           
=======================================
  Hits         1403     1403           
  Misses        990      990           

@clelange
Copy link
Contributor Author

I don't understand commitlint, please suggest a working commit message.

@mdonadoni
Copy link
Member

Thanks! I will have a look now, but in any case I will move this to reana-commons (keeping your authorship, if that's ok for you)

I don't understand commitlint, please suggest a working commit message.

We have recently started appending the PR number at the end of the commit message, so that it is added to the automatically-generated changelog: ... (#707). In any case no need to fix this, as I will close this PR after opening the one in reana-commons

@clelange
Copy link
Contributor Author

Thanks! I will have a look now, but in any case I will move this to reana-commons (keeping your authorship, if that's ok for you)

Sure, whatever makes sense to you!

@mdonadoni
Copy link
Member

Closing as this will be fixed in reanahub/reana-commons#444

@mdonadoni mdonadoni closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: broken snakemake environment when installing reana-client in Python 3.11
2 participants