Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models: missing foreign key in Job table #210

Closed
mdonadoni opened this issue Nov 20, 2023 · 0 comments · Fixed by #214 · May be fixed by #231
Closed

models: missing foreign key in Job table #210

mdonadoni opened this issue Nov 20, 2023 · 0 comments · Fixed by #214 · May be fixed by #231
Assignees
@mdonadoni
Labels
priority/soon

Comments

@mdonadoni
Copy link
Member

There is a missing foreign key constraint for workflow_uuid in the Job table:

reana-db/reana_db/models.py

Line 817 in 589978b

workflow_uuid = Column(UUIDType)

Migration scripts also need to be prepared. Beware that in already existing instances of REANA there might be orphaned jobs (i.e. jobs without the related workflow) as in the past it was possible to hard-delete workflows (see reanahub/reana-client#436).
@mdonadoni mdonadoni self-assigned this Nov 24, 2023
mdonadoni added a commit to mdonadoni/reana-db that referenced this issue Nov 24, 2023
@mdonadoni
models: add missing foreign key on workflow_uuid of Job
eed04a6 
Closes reanahub#210
mdonadoni added a commit to mdonadoni/reana-db that referenced this issue Nov 24, 2023
@mdonadoni
models: add missing foreign key to workflow_uuid of Job
cd39c65 
Closes reanahub#210
@mdonadoni mdonadoni mentioned this issue Nov 24, 2023
Merged
mdonadoni added a commit to mdonadoni/reana-db that referenced this issue May 31, 2024
@mdonadoni
models: add missing foreign key to workflow_uuid of Job
0e3237b 
Closes reanahub#210
mdonadoni added a commit to mdonadoni/reana-db that referenced this issue May 31, 2024
@mdonadoni
fix(models): add missing foreign key to workflow_uuid of Job (reanahu…
30190e0 
…b#214)

Closes reanahub#210
@mdonadoni mdonadoni added this to 0.95.0 Aug 8, 2024
@mdonadoni mdonadoni moved this to In review in 0.95.0 Aug 8, 2024
mdonadoni added a commit to mdonadoni/reana-db that referenced this issue Aug 9, 2024
@mdonadoni
fix(models): add missing foreign key to workflow_uuid of Job (reanahu…
b59e87f 
…b#214)

Closes reanahub#210
mdonadoni added a commit to mdonadoni/reana-db that referenced this issue Aug 9, 2024
@mdonadoni
fix(models): add missing foreign key to workflow_uuid of Job (reanahu…
8bf27ba 
…b#214)

Closes reanahub#210
@github-project-automation github-project-automation bot moved this from In review to Done in 0.95.0 Aug 23, 2024
@github-actions github-actions bot mentioned this issue Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdonadoni mdonadoni

Labels
priority/soon
Projects
0.95.0
Status: Done
Milestone
No milestone
1 participant
@mdonadoni