Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rucio and switch to centos7 #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .hadolint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@ ignored:
- DL3003
- DL3008
- DL3015
- DL3033
- DL3013
59 changes: 35 additions & 24 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
# Environment: ROOT6 on Ubuntu/Bionic:
FROM ubuntu:bionic
RUN apt-get -y update && \
apt-get -y install \
FROM rootproject/root:6.24.06-centos7

USER root
RUN yum install -y \
binutils \
build-essential \
cmake \
cmake3 \
cpp \
dpkg-dev \
epel-release \
g++ \
gcc \
gfal2-all \
gfal2-util \
gfortran \
git \
graphviz-dev \
Expand Down Expand Up @@ -36,28 +40,35 @@ RUN apt-get -y update && \
openssl \
python-dev \
python-pip \
python3-gfal2 \
python3 \
python3-pip \
xlibmesa-glu-dev \
zlib1g-dev && \
rm -rf /var/lib/apt/lists/* && \
apt-get -y autoremove && \
apt-get -y clean
yum clean all && \
rm -rf /var/cache/yum

ENV ROOTSYS /usr/local
RUN git clone --quiet --depth 1 --branch v6-18-04 http://root.cern.ch/git/root.git /code/root && \
cd /code && \
mkdir _build && \
cd _build && \
cmake -Dcxx17=On -Dbuiltin_xrootd=On ../root && \
cmake --build . -- -j3 && \
cmake -P cmake_install.cmake && \
# gfal2-python bindings
RUN curl -o /etc/yum.repos.d/gfal2-repo.repo https://dmc-repo.web.cern.ch/dmc-repo/dmc-el7.repo && \
git clone --branch v1.12.0 https://github.com/cern-fts/gfal2-python.git && \
cd gfal2-python/ && \
./ci/fedora-packages.sh && \
cd packaging/ && \
RPMBUILD_SRC_EXTRA_FLAGS="--without docs --without python2" make srpm && \
yum-builddep -y python3-gfal2 && \
yum clean all && \
pip install gfal2-python && \
cd / && \
rm -rf /code
rm -rf gfal2-python && \
rm -rf /var/cache/yum

RUN pip3 install rucio-clients==1.29.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to separate (i) move of the base image and (ii) addition of Rucio clients in two separate commits.

The second is really optional to have in a ROOT environment image, and may not be wanted by everybody. Hence calling for separate commits for separate feature changes here.


# EGI trust anchors
RUN curl -Lo /etc/yum.repos.d/EGI-trustanchors.repo https://repository.egi.eu/sw/production/cas/1/current/repo-files/EGI-trustanchors.repo && \
yum -y install ca-certificates ca-policy-egi-core && \
yum clean all && \
rm -rf /var/cache/yum

# Set helpful environment variables to point to local ROOT installation
ENV CMAKE_PREFIX_PATH=/usr/local
ENV DYLD_LIBRARY_PATH=/usr/local/lib
ENV JUPYTER_PATH=/usr/local/etc/notebook
ENV LD_LIBRARY_PATH=/usr/local/lib
ENV LIBPATH=/usr/local/lib
ENV PYTHONPATH=/usr/local/lib
ENV SHLIB_PATH=/usr/local/lib
USER user
WORKDIR /home/user