Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache: investigate and possibly disable caching #422

Closed
mdonadoni opened this issue Jan 17, 2024 · 1 comment · Fixed by #435 or #419
Closed

cache: investigate and possibly disable caching #422

mdonadoni opened this issue Jan 17, 2024 · 1 comment · Fixed by #435 or #419
Assignees

Comments

@mdonadoni
Copy link
Member

Caching has caused an issue recently (see #420) even though it is not enabled in REANA. In particular, the config variable CACHE_ENABLED is used in reana-workflow-engine-serial to disable the caching mechanism, but it seems like this is not enough as there is more caching logic in reana-job-controller that is always executed for every workflow.

We should investigate what this logic is doing and whether it's safe to disable it using the same CACHE_ENABLED flag. Note that this should improve performance, as currently we are saving lots of file metadata to the database, even though they are then not used:

def cache_job(self):
"""Cache a job."""
workflow = (
Session.query(Workflow).filter_by(id_=self.workflow_uuid).one_or_none()
)
access_times = calculate_file_access_time(workflow.workspace_path)
prepared_job_cache = JobCache()
prepared_job_cache.job_id = self.job_id
prepared_job_cache.access_times = access_times
Session.add(prepared_job_cache)
Session.commit()

@mdonadoni
Copy link
Member Author

Caching in reana-job-controller has been disabled as it was already disabled in reana-workflow-engine-serial and to improve performance (see the graphs in #435)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant