fix(set_workflow_status): publish workflows to submission queue (#691) #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jul 1, 2024
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maint-0.9 #691 +/- ##
=============================================
+ Coverage 59.46% 60.00% +0.54%
=============================================
Files 32 32
Lines 3298 3328 +30
=============================================
+ Hits 1961 1997 +36
+ Misses 1337 1331 -6
|
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jul 2, 2024
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jul 2, 2024
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jul 3, 2024
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
tiborsimko
reviewed
Jul 3, 2024
| @@ -1374,6 +1413,10 @@ def set_workflow_status(workflow_id_or_name, user): # noqa | |||
| description: Required. New workflow status. | |||
| required: true | |||
| type: string | |||
| enum: | |||
| - start | |||
There was a problem hiding this comment.
Hmm, this may look a bit inconsistent, it would be preferable to use either "start/stop/delete" (verbs) or "started/stopped/deleted" (nouns) everywhere ... but I guess this may not be for now.
(... for the API 1.0 stabilisation we could also clean mixing params/options for execution with all-runs/workspace for deletion...)
There was a problem hiding this comment.
Yeah, this comes from RWC, so not much we can do as of now: https://github.com/reanahub/reana-workflow-controller/blob/f1764ed7101fa9d30516b8687b7e5ef4ae8781fe/reana_workflow_controller/rest/workflows_status.py#L34-L37
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
tiborsimko
approved these changes
Jul 3, 2024
tiborsimko
added a commit
to tiborsimko/reana-server
that referenced
this pull request
Dec 4, 2024
chore(maint-0.9): release 0.9.4 (reanahub#666) build(python): bump shared REANA packages as of 2024-11-28 (reanahub#714) feat(ext): improve error message for db decryption error (reanahub#713) feat(config): make ACCOUNTS_USERINFO_HEADERS customisable (reanahub#713) feat(config): make APP_DEFAULT_SECURE_HEADERS customisable (reanahub#713) feat(config): make PROXYFIX_CONFIG customisable (reanahub#713) fix(config): do not set DEBUG programmatically (reanahub#713) feat(config): support password-protected redis (reanahub#713) fix(config): read secret key from env (reanahub#713) chore(docker): pin setuptools 70 (reanahub#700) fix(set_workflow_status): publish workflows to submission queue (reanahub#691) ci(commitlint): improve checking of merge commits (reanahub#689) fix(get_workflow_specification): avoid returning null parameters (reanahub#689) fix(start): validate endpoint parameters (reanahub#689) fix(reana-admin): respect service domain when cleaning sessions (reanahub#687) Note: The merge commit removes the changes related to pinning `setuptools` to version 70, because this was only necessary for the `maint-0.9` branches, as well as other 0.9.4 release-related changes.
tiborsimko
added a commit
to tiborsimko/reana-server
that referenced
this pull request
Dec 4, 2024
chore(maint-0.9): release 0.9.4 (reanahub#666) build(python): bump shared REANA packages as of 2024-11-28 (reanahub#714) feat(ext): improve error message for db decryption error (reanahub#713) feat(config): make ACCOUNTS_USERINFO_HEADERS customisable (reanahub#713) feat(config): make APP_DEFAULT_SECURE_HEADERS customisable (reanahub#713) feat(config): make PROXYFIX_CONFIG customisable (reanahub#713) fix(config): do not set DEBUG programmatically (reanahub#713) feat(config): support password-protected redis (reanahub#713) fix(config): read secret key from env (reanahub#713) chore(docker): pin setuptools 70 (reanahub#700) fix(set_workflow_status): publish workflows to submission queue (reanahub#691) ci(commitlint): improve checking of merge commits (reanahub#689) fix(get_workflow_specification): avoid returning null parameters (reanahub#689) fix(start): validate endpoint parameters (reanahub#689) fix(reana-admin): respect service domain when cleaning sessions (reanahub#687) Note: The merge commit removes the changes related to pinning `setuptools` to version 70, because this was only necessary for the `maint-0.9` branches, as well as other 0.9.4 release-related changes.
tiborsimko
added a commit
to tiborsimko/reana-server
that referenced
this pull request
Dec 4, 2024
chore(maint-0.9): release 0.9.4 (reanahub#666) build(python): bump shared REANA packages as of 2024-11-28 (reanahub#714) feat(ext): improve error message for db decryption error (reanahub#713) feat(config): make ACCOUNTS_USERINFO_HEADERS customisable (reanahub#713) feat(config): make APP_DEFAULT_SECURE_HEADERS customisable (reanahub#713) feat(config): make PROXYFIX_CONFIG customisable (reanahub#713) fix(config): do not set DEBUG programmatically (reanahub#713) feat(config): support password-protected redis (reanahub#713) fix(config): read secret key from env (reanahub#713) chore(docker): pin setuptools 70 (reanahub#700) fix(set_workflow_status): publish workflows to submission queue (reanahub#691) ci(commitlint): improve checking of merge commits (reanahub#689) fix(get_workflow_specification): avoid returning null parameters (reanahub#689) fix(start): validate endpoint parameters (reanahub#689) fix(reana-admin): respect service domain when cleaning sessions (reanahub#687) Note: The merge commit removes the changes related to pinning `setuptools` to version 70, because this was only necessary for the `maint-0.9` branches, as well as other 0.9.4 release-related changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a new workflow, publish the workflow to the submission
queue instead of executing the workflow immediately by calling
set_workflow_statusin workflow-controller.Depends on #689
Closes #690