Skip to content

Commit

Permalink
feat(footer): link privacy notice to configured URL (#393)
Browse files Browse the repository at this point in the history
Closes #392
  • Loading branch information
mdonadoni committed Feb 9, 2024
1 parent 8d58277 commit f0edde6
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 360 deletions.
2 changes: 0 additions & 2 deletions reana-ui/src/components/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import OAuthSignin from "~/pages/signin/OAuthSignin";
import WorkflowList from "~/pages/workflowList/WorkflowList";
import WorkflowDetails from "~/pages/workflowDetails/WorkflowDetails";
import Profile from "~/pages/profile/Profile";
import PrivacyNotice from "~/pages/privacyNotice/PrivacyNotice";
import Status from "~/pages/status/Status";
import LaunchOnReana from "~/pages/launchOnReana/LaunchOnReana";
import NotFound from "~/pages/error/NotFound";
Expand Down Expand Up @@ -81,7 +80,6 @@ export default function App() {
}
/>
<Route path="/confirm/:token" element={<Confirm />} />
<Route path="/privacy-notice" element={<PrivacyNotice />} />
<Route path="/signin_callback" element={<OAuthSignin />} />
<Route
path="/"
Expand Down
12 changes: 8 additions & 4 deletions reana-ui/src/components/Footer.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,15 @@ export default function Footer() {
const config = useSelector(getConfig);
return (
<footer className={styles["footer-bottom"]}>
<span>
{config.cernRopo && (
<Link to="/privacy-notice">
<span className={styles["links"]}>
{config.privacyNoticeURL && (
<a
href={config.privacyNoticeURL}
target="_blank"
rel="noopener noreferrer"
>
<Icon name="privacy"></Icon> Privacy notice
</Link>
</a>
)}
</span>
<span className={styles["links"]}>
Expand Down
2 changes: 1 addition & 1 deletion reana-ui/src/components/Footer.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
height: 60px;
color: $gray;

.links > a {
.links > a:not(:first-child) {
margin-left: 1em;
}
}
335 changes: 0 additions & 335 deletions reana-ui/src/pages/privacyNotice/PrivacyNotice.js

This file was deleted.

16 changes: 0 additions & 16 deletions reana-ui/src/pages/privacyNotice/PrivacyNotice.module.scss

This file was deleted.

Loading

0 comments on commit f0edde6

Please sign in to comment.