Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: added generic error notification component #120

Merged
merged 1 commit into from
Sep 16, 2020
Merged

ui: added generic error notification component #120

merged 1 commit into from
Sep 16, 2020

Conversation

audrium
Copy link
Member

@audrium audrium commented Sep 14, 2020

addresses #118

diegodelemos
diegodelemos reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@diegodelemos diegodelemos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! a couple of minor comments and two that need some feedback :)

This was referenced Sep 14, 2020
Closed
Closed
Open
@tiborsimko tiborsimko merged commit e285872 into reanahub:master Sep 16, 2020
@audrium audrium mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidalgarcia mvidalgarcia mvidalgarcia left review comments

@tiborsimko tiborsimko tiborsimko approved these changes

@diegodelemos diegodelemos diegodelemos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@audrium @tiborsimko @mvidalgarcia @diegodelemos