launch: improve validation warning for unexpected properties #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
reviewed
Nov 27, 2023
| const properties = validation_warnings[key] | ||
| .map( | ||
| (additionalProperty) => | ||
| `${additionalProperty.property} (at ${additionalProperty.path})`, |
There was a problem hiding this comment.
Note that sometime the path is empty, so we should not show (at )
giuseppe-steduto
force-pushed
the
validate-fix-environment-misplaced
branch
from
f8f7ba1 to
153562e
Compare
mdonadoni
reviewed
Nov 28, 2023
reana-ui/src/client.js
Outdated
Comment on lines
31
to
33
| `${api}/api/workflows?include_progress=true&include_workspace_size=true&${stringifyQueryParams( | ||
| params, | ||
| )}`; |
There was a problem hiding this comment.
We should remove the first commit so that this URL goes back to the original one, as otherwise open interactive sessions would not be shown in the UI
Change the validation warning issued when unexpected properties are found in the REANA specification to include the path to were the invalidating keywords were found. Closes reanahub/reana-client#679.
giuseppe-steduto
force-pushed
the
validate-fix-environment-misplaced
branch
from
153562e to
47bdd5e
Compare
mdonadoni
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the validation warning issued when unexpected properties are
found in the REANA specification to include the path to were the
invalidating keywords were found.
Closes reanahub/reana-client#679.
How to test:
launch?url=https://github.com/giuseppe-steduto/reana-demo-root6-roofit/tree/reana-yaml-allow-unexpected-props&specification=reana-cwl.yamllaunch?name=roofit-warning-spec&url=https%3A%2F%2Fgithub.com%2Fgiuseppe-steduto%2Freana-demo-root6-roofit%2Ftree%2Fvalidation-tests