Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(commitlint): check for the presence of concrete PR number #562

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

tiborsimko
Copy link
Member

  • ci(commitlint): check for the presence of concrete PR number

    Enrich commitlint checker in order to check the precise PR number in the
    commit log headline.

  • ci(shellcheck): fix exit code propagation

    Return properly the exit code status of shellcheck command when looping
    through shell script files.

Return properly the exit code status of shellcheck command when looping
through shell script files.
…b#562)

Enrich commitlint checker in order to check the precise PR number in the
commit log headline.
@tiborsimko tiborsimko force-pushed the ci-commitlint-shellcheck branch from c514bd3 to 4b8f539 Compare January 25, 2024 11:09
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4be8086) 72.50% compared to head (4b8f539) 72.50%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   72.50%   72.50%           
=======================================
  Files          15       15           
  Lines        1382     1382           
=======================================
  Hits         1002     1002           
  Misses        380      380           

@tiborsimko tiborsimko merged commit 4b8f539 into reanahub:master Jan 26, 2024
14 checks passed
@tiborsimko tiborsimko deleted the ci-commitlint-shellcheck branch January 26, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants