Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sessions): get the session status from the pod state #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alputer
Copy link
Member

@Alputer Alputer commented Nov 18, 2024

@Alputer Alputer requested a review from tiborsimko November 18, 2024 11:02
@Alputer Alputer self-assigned this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 15.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (7896c61) to head (49cf295).

Files with missing lines Patch % Lines
reana_workflow_controller/k8s.py 9.09% 10 Missing ⚠️
reana_workflow_controller/rest/workflows.py 22.22% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   76.61%   75.95%   -0.66%     
==========================================
  Files          17       17              
  Lines        1847     1867      +20     
==========================================
+ Hits         1415     1418       +3     
- Misses        432      449      +17     
Files with missing lines Coverage Δ
reana_workflow_controller/rest/workflows.py 70.48% <22.22%> (-1.56%) ⬇️
reana_workflow_controller/k8s.py 78.23% <9.09%> (-5.60%) ⬇️
---- 🚨 Try these New Features:

@Alputer Alputer requested a review from mdonadoni November 18, 2024 12:53
@Alputer Alputer force-pushed the interactive-session-status-fix branch from a50932b to 49cf295 Compare November 18, 2024 16:24
@Alputer Alputer changed the title fix(sessions): get the session status from the pod state (#611) fix(sessions): get the session status from the pod state Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Jupyter icon when only when notebook is available
1 participant