Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: shared modules are not upgraded correctly #412

Closed
audrium opened this issue Sep 24, 2020 · 3 comments · Fixed by #423
Closed

cli: shared modules are not upgraded correctly #412

audrium opened this issue Sep 24, 2020 · 3 comments · Fixed by #423
Assignees

Comments

@audrium
Copy link
Member

audrium commented Sep 24, 2020

Running reana-dev git-upgrade-shared-modules -c r-server requirements (in setup.py) were upgraded to the following:

- "reana-db>=0.7.0a6,<0.8.0",
+ "reana-db>=0.8.0a1,<0.8.0",

while the correct output would be:
"reana-db>=0.8.0a1,<0.9.0",

@tiborsimko
Copy link
Member

This is connected to the fact that master is now being used for both 0.7.0 work and 0.8.0 work.

We need to start maint-0.7 branches rapidly so that we can cleanly separate these works. Then we'll be able to amend setup requirements everywhere.

Note also #413 that is related and that will come very handy for these situations.

@tiborsimko
Copy link
Member

maint-0.7 created everywhere in CLIENT and CLUSTER repositories, and there are many PRs to update master lower pins, so this will be fixed soon.

@tiborsimko
Copy link
Member

OK, installation problem fixed... Remains to amend git-upgrade-shared-modules command to properly upgrade top boundary, which was the core of the issue 😉

@mvidalgarcia mvidalgarcia self-assigned this Oct 9, 2020
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Oct 9, 2020
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants