Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: create RS egg-info generated when DEBUG #198

Merged
merged 1 commit into from
Sep 11, 2019
Merged

makefile: create RS egg-info generated when DEBUG #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ help:
@echo
@echo ' # Example 3: build and deploy REANA in development mode (with live code changes and debugging)'
@echo ' $$ minikube mount $$(pwd)/..:/code'
@echo ' $$ cd reana-server && pip install -e . && cd .. # workaround for reana-workflow-controller#64'
@echo ' $$ CLUSTER_CONFIG=dev make build deploy'
@echo
@echo ' # Example 4: run one small demo example to verify the build'
Expand Down Expand Up @@ -107,6 +106,12 @@ build: # Build REANA client and cluster components.
pip uninstall -y reana-commons reana-client reana-cluster reana-db pytest-reana && \
reana-dev install-client && \
reana-dev install-cluster && \
if [ "${DEBUG}" -gt 0 ]; then \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If DEBUG is guaranteed to be numerical, we could leave out the double quotes, here and in the other statement, I guess... Although this works well too.

cd ${PWD}/../reana-server/ && \
python setup.py bdist_egg && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we have a line in "Example 3" that tells people they have to run pip install in reana-server. If we do it for them, we can delete that line above 😉

cd -; \
fi && \
pip check && \
reana-dev git-submodule --update && \
reana-dev docker-build -b DEBUG=${DEBUG} && \
reana-dev git-submodule --delete && \
Expand Down