fix(reana-dev): update container image labels when releasing (#765) #765
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 18.56% 18.54% -0.02%
==========================================
Files 26 26
Lines 2359 2372 +13
==========================================
+ Hits 438 440 +2
- Misses 1921 1932 +11
|
…ahub#765) Fixes `reana-dev git-create-release-commit` behaviour to also update the container image label version when releasing the cluster components
tiborsimko
force-pushed
the
git-create-release-commit-update-dockerfile-labels
branch
from
a256355 to
813eca3
Compare
tiborsimko
changed the title
git-create-release-commit update image labels (#765)
…ahub#765) Fixes `reana-dev git-create-release-commit` behaviour to also update the container image label version when releasing the cluster components
tiborsimko
force-pushed
the
git-create-release-commit-update-dockerfile-labels
branch
from
813eca3 to
04db78a
Compare
…ahub#765) Fixes `reana-dev git-create-release-commit` behaviour to also update the container image label version when releasing the cluster components.
tiborsimko
force-pushed
the
git-create-release-commit-update-dockerfile-labels
branch
from
04db78a to
75516da
Compare
There was a problem hiding this comment.
How do we want to update the date in the Dockerfile, also considering that we are switching to release-please?
There was a problem hiding this comment.
I guess we'd have to update it ourselves at the day we are releasing and compiling the user-facing summary to be put into CHANGELOG before the regular news items generated by Release Please.
Might be nice to script it further, we would probably need to read upstream/release-please--branches--master branch content, enrich it and push back. Perhaps a job for a new command?
There was a problem hiding this comment.
But the user-facing summary would only be for the general reana repository, wouldn't it? I would avoid having an user-facing summary for each component, as I think that 1) that would not be very useful to the users in any case 2) it would cancel the benefit of using conventional commits and release-please by introducing a manual step in what could otherwise be a fully automatic release.
Regarding the second point, if we want to script it then I guess we could remove the label from the Dockerfile itself, and then set it from the CLI when building the image (either with reana-dev or with our custom GitHub action). In this way we would not need a new command, and we could still use release-please PRs without having to modify them.
What do you think?
There was a problem hiding this comment.
WRT user-facing summaries, fully agree about doing it only for the user-facing repositories, such as reana and perhaps some like reana-client, reana-client-go. We may not even need them for every patchlevel release, only for "big" releases (major, and perhaps minor).
WRT updating also date, (a) I could amend git-create-release-commit command to do this too; (b) removing this label from Dockerfile could also be interesting at a slight con of not having full labels in the source code repository; (c) BTW we also do need to be aware of updating the date in the Release Please's made pull request, if the release is not happening the same day. We can see IRL about pros/cons?
…b#765) Fixes `reana-dev git-create-release-commit` behaviour to also update the container image label version when releasing the cluster components.
tiborsimko
force-pushed
the
git-create-release-commit-update-dockerfile-labels
branch
from
75516da to
12deebf
Compare
tiborsimko
changed the title
git-create-release-commit update image labels (#765)…b#765) Fixes `reana-dev git-create-release-commit` behaviour to also update the container image label version when releasing the cluster components.
tiborsimko
force-pushed
the
git-create-release-commit-update-dockerfile-labels
branch
from
12deebf to
d54ffe7
Compare
…b#765) Fixes `reana-dev git-create-release-commit` behaviour to also update the container image label version when releasing the cluster components.
tiborsimko
force-pushed
the
git-create-release-commit-update-dockerfile-labels
branch
from
d54ffe7 to
fe6bc2c
Compare
tiborsimko
deleted the
git-create-release-commit-update-dockerfile-labels
branch
Changes
reana-dev git-create-release-commitbehaviour to also update the container image label version when releasing cluster components.