fix(helm): allow interactive-session-cleanup job to access RWC (#820) #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
=======================================
Coverage 19.22% 19.22%
=======================================
Files 26 26
Lines 2512 2512
=======================================
Hits 483 483
Misses 2029 2029 |
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Aug 9, 2024
mdonadoni
force-pushed
the
network-policy-session-cleanup
branch
from
7028e7a to
0d608ee
Compare
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Aug 26, 2024
mdonadoni
force-pushed
the
network-policy-session-cleanup
branch
from
0d608ee to
ed3fe16
Compare
mdonadoni
force-pushed
the
network-policy-session-cleanup
branch
from
ed3fe16 to
a288636
Compare
tiborsimko
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Works nicely 👍
With master branch:
$ kubectl logs reana-interactive-session-cleanup1-m6zxt | grep -v InsecureRequestWarning: | grep -v warnings.warn
Starting to close interactive sessions running longer than 0 days..
Fetching interactive session pods..
Couldn't close interactive session 'reana-run-session-b6e2a0a2-a544-42ca-9837-82044bd29d2d-744m5v6v':With this PR:
$ kubectl logs reana-interactive-session-cleanup2-phh6s | grep -v InsecureRequestWarning: | grep -v warnings.warn
Starting to close interactive sessions running longer than 0 days..
Fetching interactive session pods..
Interactive session 'reana-run-session-b6e2a0a2-a544-42ca-9837-82044bd29d2d-744m5v6v' has been closed.
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Dec 2, 2024
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Dec 2, 2024
…hub#820) Closes reanahub/reana-server#694 (cherry picked from commit a288636)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-server#694