chore: comment out test #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to keep the tests skipped until this fix lands 👍🏼 |
There might be a point release 3.8.1 soon as there was some regression related to Coq, maybe the fix in 7849 will be included in that release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what exactly to do about this, but it looks like a) writing this melange test and b) having reactjs-ppx in this repository will require dune 3.9 because of ocaml/dune#7849.
My proposal is to comment it out until we can require
(dune lang 3.9)after the next dune release. In the meantime we can uncomment it to run the tests for local development.What do you think, @davesnx?