Fix installation and tests #744
Conversation
…lange-0-11 * 'main' of github.com:/reasonml/reason-react: Fix installation and tests (#744)
|
Why do we require dune 3.9? |
|
We don't but this just installs the same version on local than on CI. The requirement is still 3.6.0 |
| @@ -1,4 +1,4 @@ | |||
| (lang dune 3.8) | |||
| (lang dune 3.9) | |||
There was a problem hiding this comment.
This change is clearly requiring 3.9
There was a problem hiding this comment.
Oh, thought you talked about Reason, not dune.
There was a problem hiding this comment.
This was done after 3.9 and melange from master: https://github.com/reasonml/reason-react/pull/744/files#diff-7952def243577f0f6e0695a0199602f14094f8d6c77eec1c0b3dc63e9e84b2fdL38-L45
There was a problem hiding this comment.
But melange only requires dune 3.8
There was a problem hiding this comment.
The current state of this repo is very broken, since it requires melange master and Reason 3.9.0 for the snapshot testing + the reason-react-ppx from the repo
So there should be a few things to un-tangle before we can even publish newer versions
Install Reason v3.9.0 on make install and run snapshots with it.