Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize bsconfig.json and package.json before publish #296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WhyThat
Copy link

@WhyThat WhyThat commented May 11, 2021

Hey,
This is an attempt to fix #267 by removing bisect_ppx from the published package outputs are

{
  "name": "relude",
  "description": "Alternative standard library (prelude) for ReasonML",
  "homepage": "https://github.com/reazen/relude",
  "bugs": "https://github.com/reazen/relude/issues",
  "version": "0.65.0",
  "repository": {
    "type": "git",
    "url": "https://github.com/reazen/relude.git"
  },
  "scripts": {
    "clean": "bsb -clean-world",
    "build": "bsb -make-world",
    "watch": "bsb -make-world -w",
    "test": "jest",
    "coverage": "npm run test",
    "docs": "docsify serve ./docs",
    "cleanbisect": "rm bisect*.coverage || true",
    "cleanbuild": "npm run clean && npm run build",
    "cleanwatch": "npm run clean && npm run watch",
    "cleantest": "npm run cleanbuild && npm run test",
    "cleancoverage": "npm run cleanbisect && BISECT_ENABLE=yes npm run cleanbuild && npm run coverage",
    "prepack": "node scripts/prepack.js",
    "releasebuild": "npm run cleancoverage"
  },
  "keywords": [
    "ReasonML",
    "BuckleScript",
    "Utility",
    "Prelude",
    "Standard Library"
  ],
  "author": "",
  "license": "MIT",
  "devDependencies": {
    "@glennsl/bs-jest": "^0.5.1",
    "bs-bastet": "^1.2.5",
    "bs-platform": "^7.2.2",
    "docsify-cli": "~4.4.0"
  },
  "peerDependencies": {
    "bs-bastet": "^1.2.5",
    "bs-platform": "^7.2.2"
  },
  "dependencies": {},
  "jest": {
    "verbose": false,
    "testPathIgnorePatterns": [
      "/node_modules/",
      "/testUtils/"
    ],
    "setupFilesAfterEnv": [
      "bisect_ppx/lib/js/src/runtime/bucklescript/jest.js"
    ]
  }
}

and

{
  "name": "relude",
  "bsc-flags": [
    "-bs-no-version-header",
    "-bs-super-errors"
  ],
  "version": "0.1.0",
  "sources": [
    {
      "dir": "src",
      "subdirs": true
    },
    {
      "dir": "__tests__",
      "subdirs": true,
      "type": "dev"
    }
  ],
  "package-specs": {
    "module": "commonjs",
    "in-source": false
  },
  "suffix": ".bs.js",
  "bs-dependencies": [
    "bs-bastet"
  ],
  "bs-dev-dependencies": [
    "@glennsl/bs-jest"
  ],
  "warnings": {
    "number": "+A-4-40-42",
    "error": "+A"
  },
  "namespace": false,
  "refmt": 3
}

remove dependencie to bisect_ppx because it's not needed in the
published package
@WhyThat
Copy link
Author

WhyThat commented Jun 2, 2021

Any thoughts on this solution ?

@andywhite37
Copy link
Member

Sorry for the long delay - I think we were waiting to see how this panned out with bs-bastet, but I've sort of lost track of that too. I think the solution might be to just get rid of bisect_ppx completely - it seems to be having some other issues at this point. One option would be to go back to just using jest --coverage, which is not ideal, but also not the end of the world. Open to feedback on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change bisect_ppx to dev dependency when possible
2 participants