Merge branch 'AsBuiltReport:dev' into dev

rebelinux · Jun 25, 2024 · 04d707a · 04d707a
2 parents c992a42 + 46df690
commit 04d707a
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/.github/workflows/Release.yml b/.github/workflows/Release.yml
@@ -33,7 +33,7 @@ jobs:
     needs: publish-to-gallery
     runs-on: ubuntu-latest
     steps:
-      - uses: Eomm/why-don-t-you-tweet@v1
+      - uses: rebelinux/why-don-t-you-tweet@v1.2
         # We don't want to tweet if the repository is not a public one
         if: ${{ !github.event.repository.private }}
         with:

diff --git a/AsBuiltReport.Microsoft.Windows.psd1 b/AsBuiltReport.Microsoft.Windows.psd1
@@ -54,7 +54,7 @@
     RequiredModules = @(
         @{
             ModuleName = 'AsBuiltReport.Core';
-            ModuleVersion = '1.3.0'
+            ModuleVersion = '1.4.0'
         },
         @{
             ModuleName = 'dbatools';

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.5.4] - Unreleased
+## [0.5.4] - 2024-05-16
+
+### Changed
+
+- Increase AsBuiltReport.Core module version (v1.4.0)
 
 ### Fixed
 

diff --git a/README.md b/README.md
@@ -40,8 +40,6 @@ Please refer to the AsBuiltReport [website](https://www.asbuiltreport.com) for m
 
 Sample Microsoft Windows As Built report HTML file: [Sample Microsoft Windows As-Built Report.html](https://htmlpreview.github.io/?https://raw.githubusercontent.com/AsBuiltReport/AsBuiltReport.Microsoft.Windows/dev/Samples/Sample%20Microsoft%20Windows%20As%20Built%20Report.html "Sample Microsoft Windows As-Built Report")
 
-Sample Microsoft Windows As Built report PDF file: [Sample Microsoft Windows As Built Report.pdf](https://raw.githubusercontent.com/AsBuiltReport/AsBuiltReport.Microsoft.Windows/dev/Samples/Sample%20Microsoft%20Windows%20As%20Built%20Report.pdf)
-
 # :beginner: Getting Started
 
 Below are the instructions on how to install, configure and generate a Microsoft Windows As Built report.
@@ -50,7 +48,7 @@ Below are the instructions on how to install, configure and generate a Microsoft
 <!-- ********** Update supported Windows versions ********** -->
 The Microsoft Windows As Built Report supports the following Windows Server versions;
 
-- 2012, 2016, 2019 & 2022
+- 2016, 2019 & 2022
 
 ### PowerShell
 
@@ -257,3 +255,5 @@ PS C:\> New-AsBuiltReport -Report Microsoft.Windows -Target 'win-server-01v.cont
 
 - Issues with WinRM when using the IP address instead of the "Fully Qualified Domain Name".
 - The report provides the ability to extract the configuration of the DNS/DHCP/Hyper-V/IIS/FailOver-Cluster services. In order to obtain this information it is required that the servers running these services have the corresponding powershell modules installed.
+- Issues when running the report against Windows Server 2012 and 2012 R2.
+  - Error: "Exception calling Save with 1 argument(s): hexadecimal value 0x00, is an invalid character."
diff --git a/Src/Private/Get-AbrWinOSConfig.ps1 b/Src/Private/Get-AbrWinOSConfig.ps1
@@ -27,7 +27,7 @@ function Get-AbrWinOSConfig {
     process {
         if ($InfoLevel.OperatingSystem -ge 1) {
             Section -Style Heading3 'OS Configuration' {
-                Paragraph 'The following section details hos OS configuration'
+                Paragraph 'The following section details host OS configuration'
                 BlankLine
                 $HostOSReport = [PSCustomObject] @{
                     'Windows Product Name' = $HostInfo.WindowsProductName
@@ -64,4 +64,4 @@ function Get-AbrWinOSConfig {
         }
     }
     end {}
-}
+}