Commands improvements

CHANGELOG.md

@@ -50,6 +50,7 @@ CHANGELOG
 ## Changed
 - The type resolver is now able to resolve the top level types 'Query',
   'Mutation' and 'Subscription'
+- Return types were added to all methods of the commands [\#1005 / sforward](https://github.com/rebing/graphql-laravel/pull/1005)
 
 2023-02-18, 8.6.0
 -----------------

src/Console/EnumMakeCommand.php

@@ -4,24 +4,26 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:enum')]
 class EnumMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:enum {name}';
     protected $description = 'Create a new GraphQL enum class';
     protected $type = 'Enum';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/enum.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Enums';
     }
 
-    protected function buildClass($name)
+    protected function buildClass($name): string
     {
         $stub = parent::buildClass($name);
 

src/Console/ExecutionMiddlewareMakeCommand.php

@@ -4,19 +4,21 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:executionMiddleware')]
 class ExecutionMiddlewareMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:executionMiddleware {name}';
     protected $description = 'Create a new GraphQL execution middleware class';
     protected $type = 'ExecutionMiddleware';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/executionMiddleware.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Middleware\Execution';
     }

src/Console/FieldMakeCommand.php

@@ -4,19 +4,21 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:field')]
 class FieldMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:field {name}';
     protected $description = 'Create a new GraphQL field class';
     protected $type = 'Field';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/field.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Fields';
     }

src/Console/InputMakeCommand.php

@@ -4,24 +4,26 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:input')]
 class InputMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:input {name}';
     protected $description = 'Create a new GraphQL input class';
     protected $type = 'Input';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/input.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Inputs';
     }
 
-    protected function buildClass($name)
+    protected function buildClass($name): string
     {
         $stub = parent::buildClass($name);
 

src/Console/InterfaceMakeCommand.php

@@ -4,24 +4,26 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:interface')]
 class InterfaceMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:interface {name}';
     protected $description = 'Create a new GraphQL interface class';
     protected $type = 'Interface';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/interface.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Interfaces';
     }
 
-    protected function buildClass($name)
+    protected function buildClass($name): string
     {
         $stub = parent::buildClass($name);
 

src/Console/MiddlewareMakeCommand.php

@@ -4,19 +4,21 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:middleware')]
 class MiddlewareMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:middleware {name}';
     protected $description = 'Create a new GraphQL middleware class';
     protected $type = 'Middleware';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/middleware.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Middleware';
     }

src/Console/MutationMakeCommand.php

@@ -4,24 +4,26 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:mutation')]
 class MutationMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:mutation {name}';
     protected $description = 'Create a new GraphQL mutation class';
     protected $type = 'Mutation';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/mutation.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Mutations';
     }
 
-    protected function buildClass($name)
+    protected function buildClass($name): string
     {
         $stub = parent::buildClass($name);
 

src/Console/QueryMakeCommand.php

@@ -4,24 +4,26 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:query')]
 class QueryMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:query {name}';
     protected $description = 'Create a new GraphQL query class';
     protected $type = 'Query';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/query.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Queries';
     }
 
-    protected function buildClass($name)
+    protected function buildClass($name): string
     {
         $stub = parent::buildClass($name);
 

src/Console/ScalarMakeCommand.php

@@ -4,19 +4,21 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:scalar')]
 class ScalarMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:scalar {name}';
     protected $description = 'Create a new GraphQL scalar class';
     protected $type = 'Scalar';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/scalar.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Scalars';
     }

src/Console/SchemaConfigMakeCommand.php

@@ -4,19 +4,21 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:schemaConfig')]
 class SchemaConfigMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:schemaConfig {name}';
     protected $description = 'Create a new GraphQL schema configuration class';
     protected $type = 'Schema';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/schemaConfig.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Schemas';
     }

src/Console/TypeMakeCommand.php

@@ -4,24 +4,26 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:type')]
 class TypeMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:type {name}';
     protected $description = 'Create a new GraphQL type class';
     protected $type = 'Type';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/type.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Types';
     }
 
-    protected function buildClass($name)
+    protected function buildClass($name): string
     {
         $stub = parent::buildClass($name);
 

src/Console/UnionMakeCommand.php

@@ -4,24 +4,26 @@
 namespace Rebing\GraphQL\Console;
 
 use Illuminate\Console\GeneratorCommand;
+use Symfony\Component\Console\Attribute\AsCommand;
 
+#[AsCommand('make:graphql:union')]
 class UnionMakeCommand extends GeneratorCommand
 {
     protected $signature = 'make:graphql:union {name}';
     protected $description = 'Create a new GraphQL union class';
     protected $type = 'Union';
 
-    protected function getStub()
+    protected function getStub(): string
     {
         return __DIR__ . '/stubs/union.stub';
     }
 
-    protected function getDefaultNamespace($rootNamespace)
+    protected function getDefaultNamespace($rootNamespace): string
     {
         return $rootNamespace . '\GraphQL\Unions';
     }
 
-    protected function buildClass($name)
+    protected function buildClass($name): string
     {
         $stub = parent::buildClass($name);
 

src/GraphQLServiceProvider.php

@@ -130,17 +130,19 @@ public function registerGraphQL(): void
      */
     public function registerConsole(): void
     {
-        $this->commands(EnumMakeCommand::class);
-        $this->commands(FieldMakeCommand::class);
-        $this->commands(InputMakeCommand::class);
-        $this->commands(InterfaceMakeCommand::class);
-        $this->commands(InterfaceMakeCommand::class);
-        $this->commands(MiddlewareMakeCommand::class);
-        $this->commands(MutationMakeCommand::class);
-        $this->commands(QueryMakeCommand::class);
-        $this->commands(ScalarMakeCommand::class);
-        $this->commands(SchemaConfigMakeCommand::class);
-        $this->commands(TypeMakeCommand::class);
-        $this->commands(UnionMakeCommand::class);
+        $this->commands([
+            EnumMakeCommand::class,
+            FieldMakeCommand::class,
+            InputMakeCommand::class,
+            InterfaceMakeCommand::class,
+            InterfaceMakeCommand::class,
+            MiddlewareMakeCommand::class,
+            MutationMakeCommand::class,
+            QueryMakeCommand::class,
+            ScalarMakeCommand::class,
+            SchemaConfigMakeCommand::class,
+            TypeMakeCommand::class,
+            UnionMakeCommand::class,
+        ]);
     }
 }