Skip to content

Fix type declaration mismatch in scalar stub #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
Merged

Fix type declaration mismatch in scalar stub #1190

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2109ee
fix(scalar): update properties to use typed declarations
iisyos Oct 29, 2025
342f363
Add changelog entry
iisyos Oct 29, 2025
26393b9
test: update unit to assert typed property declarations in generated …
iisyos Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ CHANGELOG

[Next release](https://github.com/rebing/graphql-laravel/compare/9.11.0...master)

### Fixed
- Fixed type declaration mismatch in scalar type classes generated by `make:graphql:scalar` command by removing premature type hints from the stub [\#1190 / iisyos](https://github.com/rebing/graphql-laravel/pull/1190)

2025-10-07, 9.11.0
------------------

Expand Down
6 changes: 3 additions & 3 deletions src/Console/stubs/scalar.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ class DummyClass extends ScalarType implements TypeConvertible
/**
* @var string
*/
public $name = 'DummyClass';
public string $name = 'DummyClass';

/**
* @var string
* @var ?string
*/
public $description = '';
public ?string $description = '';

/**
* Serializes an internal value to include in a response.
Expand Down