Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle x-csrf-token changes via response headers #332

Closed
wants to merge 1 commit into from

Conversation

kylekatarnls
Copy link
Contributor

@kylekatarnls kylekatarnls commented Jun 17, 2019

This allows to tests queries in Graphiql even if VerifyCsrfToken is enabled with tokens passed via headers.

This allow to tests queries in Graphiql even if VerifyCsrfToken is enabled with tokens passed via headers
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mfn
Copy link
Collaborator

mfn commented Jun 17, 2019

Merged via #333

Couldn't merge this one as the test run via travis weren't triggered 🤷‍♀️

Rest assure your authorship is preserved => dbf917e

@mfn mfn closed this Jun 17, 2019
@@ -79,18 +79,22 @@ function updateURL() {
history.replaceState(null, null, newSearch);
}

var xcrsfToken = null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: crsf when it should be csrf

Whoever came up with this… 😄

@mfn mfn mentioned this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants