allow alias to be a callback #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
reviewed
Aug 16, 2019
src/Support/SelectFields.php
Outdated
| @@ -213,7 +213,7 @@ protected static function handleFields(array $queryArgs, array $requestedFields, | |||
| // Select | |||
| else { | |||
| $key = isset($fieldObject->config['alias']) | |||
| ? $fieldObject->config['alias'] | |||
| ? value($fieldObject->config['alias']) | |||
There was a problem hiding this comment.
I know these global helpers are super convenient, but the same reason they're global I despise them.
In this case this should be replaced with inline code doing the same.
tests/Database/SelectFieldsTest.php
Outdated
| ], | ||
| ], | ||
| ]; | ||
|
|
||
| $this->assertEquals($response->getStatusCode(), 200); | ||
| $this->assertEquals($expectedResult, $response->json()); | ||
|
|
||
| // clear the mock | ||
| Carbon::setTestNow(); |
There was a problem hiding this comment.
Now necessary, Laravels (and Orchestras) tearDown takes care of it
tests/Database/SelectFieldsTest.php
Outdated
| ->create([ | ||
| 'post_id' => $post->id, | ||
| 'created_at' => new DateTime('2000-01-01'), |
There was a problem hiding this comment.
I'd rather stay in "Carbon-town" everywhere.
I remember, guess I was too enthusiastic in #356 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a test actually existed for this case but just repeated the previous test