Add GraphQL context as 3rd argument to custom relation 'query' #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to mutate the context from within e.g. a GraphQL query and safely pass data down to custom relation queries. Fixes rebing#459
mfn
commented
Aug 27, 2019
| ?Closure $customQuery = null, | ||
| bool $topLevel = true, | ||
| $ctx = null | ||
| ) { |
There was a problem hiding this comment.
Decided it was time to stop this "long line" madness and finally break them; did this a way times in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to mutate the context from within e.g. a GraphQL query and safely
pass data down to custom relation queries.
The test
\Rebing\GraphQL\Tests\Database\SelectFields\QueryArgsAndContextTests\NestedRelationLoadingTest::testGraphqlQueryFlagOverridesCustomQueryThrougContextshows off the high picture working:\Rebing\GraphQL\Tests\Database\SelectFields\QueryArgsAndContextTests\GraphQLContext\Rebing\GraphQL\Tests\Database\SelectFields\QueryArgsAndContextTests\UsersQuery::resolvethe context receives the $args data'query'in\Rebing\GraphQL\Tests\Database\SelectFields\QueryArgsAndContextTests\PostType::fieldsand\Rebing\GraphQL\Tests\Database\SelectFields\QueryArgsAndContextTests\UserType::fieldsis it usedFixes #459