-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Laravel 7 support #597
Conversation
I love the composer output when it has version problems 😅 Likely orechstra needs to be bumped! |
Yes, today the branch |
kk and thanks for the initiative, much appreciated 🙏 |
Tried to retrigger jobs but still fails :-( |
The new branch of orchestra/testbench is |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@exodusanto Thanks for your effort! Can this be merged in the master so we can update to Laravel 7? What are the expected timelines for this? |
If you need to test locally Laravel 7 in the meanwhile you can use my fork dev-master as a vcs on composer |
I'm busy ATM, will review & merge ASAP => sorry! |
$error = new \Exception( | ||
$error->getMessage(), | ||
$error->getCode(), | ||
$error | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrapped the error with the Exception class to be backward-compatibile with Laravel <= 6.x
.
I had to remove the FatalThrowableError
because it doesn't exist anymore on Symfony 5
I tried to load this way, and there was a bit of error. Do you know what the problem is? {
"repositories": {
"graphql-laravel": {
"type": "package",
"package": {
"name": "exodusanto/graphql-laravel",
"version": "1.0",
"source": {
"url": "https://github.com/exodusanto/graphql-laravel",
"type": "git",
"reference": "origin/master"
}
}
}
}
} |
Hi @StringKe edit your
and after run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, very much appreciated 🙇
I've just released https://github.com/rebing/graphql-laravel/releases/tag/5.0.0-rc2 Since the 5.* cycle already started, I currently don't plan to revisit 4.x with Laravel 7 support |
https://github.com/rebing/graphql-laravel/releases/tag/5.0.0 has been released with L7 support! |
Summary
Update
illuminate/support
version🥶Waiting for Laravel 7 release=> released!Type of change
Checklist