-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic directives support #703
Conversation
* add abstract directive support * add configs info * add defaultFieldResolverWithDirectives in helper
* add abstract directive support * add configs info * add defaultFieldResolverWithDirectives in helper * add tests
* phpstan adjustments
I don't understand why the Code Analysis / Code Style checker (pull_request) step fails 😕 |
Awesome feature! Would love to see this implemented :D |
Seems we're hit by PHP-CS-Fixer/PHP-CS-Fixer#5342 ; let's not worry about this one for now! |
Yes, seems related to the version of package friendsofphp/php-cs-fixer, in other pr works with v2.16.8 but in this fails v2.17.1 (like u link above). |
I close the pr as at the moment I don't have time to continue the implementation I hope to have more time in the future. |
Summary
Attempted integration of directives support, see changes in readme for use case.
TODO
DEV NOTES
SchemaDirectiveVisitor
like in Apollo? webonyx/graphql-php#748 Feature Request: Directive Visitors / Resolvers webonyx/graphql-php#299Type of change
Checklist
composer fix-style