Return messages directly and not the bag #754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I don't think the intended output was ever to have the MessageBag
being an intermediary for serializing the response, when directly
returning the messages yields the same result.
I noticed this already when I added support for Laravels
ValidationException
directly in #748 where I already usedgetMessages()
.The gracious changes in the tests result from not having the MessageBag
available anymore and making the shortcut just comparing the whole
response.
IMHO it also gives a clearer indication how such a thing looks like
(the shape) and find the individual probes into the result harder to
grasp in the big picture.
This lead to funny things to properly assess the error payload like in adea531#diff-3843ca02a9a09b621b2ae517b99bf9f84452d016556d6d433be47d628754e392R32-R33
Type of change:
Checklist:
composer fix-style