Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more typehints #849

Merged
merged 16 commits into from
Nov 6, 2021
Merged

Add more typehints #849

merged 16 commits into from
Nov 6, 2021

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Nov 6, 2021

Summary

Mostly about array types

This brings down phpstan errors from 388 to 305.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

mfn added 15 commits November 6, 2021 23:44
@mfn
Add typehint for \Rebing\GraphQL\Support\Type::$attributes
2e0b58a 
Also update phpstan baseline due to this change.
@mfn
Add typehint for \Rebing\GraphQL\GraphQL::addTypes
3334074 
Also update phpstan baseline.
@mfn
Add typehint for $opts
b6e7900 
Also update phpstan baseline.
@mfn
Add typehint for $fields
6d4f872 
Also update phpstan baseline.
@mfn
Add typehint for \Rebing\GraphQL\Support\Field::toArray
77a91f3 
Also update phpstan baseline.
@mfn
Add typehint for \Rebing\GraphQL\GraphQL::formatError
c164102 
Also update phpstan baseline.
@mfn
Add typehint for \Rebing\GraphQL\GraphQL::getSchemas
0628e7f 
Also update phpstan baseline.
@mfn
Clarify typehint for \Rebing\GraphQL\GraphQL::objectType($type)
75e13bb 
Also update phpstan baseline.
@mfn
Reuse existing $paramType instead of refetching the type
04076a7
@mfn
Add typehint for \Rebing\GraphQL\Support\Type::attributes
e3ff408 
Also update phpstan baseline.
@mfn
Add typehint for \Rebing\GraphQL\Support\Type::__set($mixed)
4280765 
Also update phpstan baseline.
@mfn
Add typehint for \Rebing\GraphQL\Support\Type::getAttributes()
1db44f6 
Also update phpstan baseline.
@mfn
Add typehint for \Rebing\GraphQL\Support\Type::getFields()
16b8e57 
Also update phpstan baseline.
@mfn
Add typehint for \Rebing\GraphQL\Support\Type::interfaces()
b55e72b 
Also update phpstan baseline.
@mfn
Add typehint for \Rebing\GraphQL\Support\Type::toArray()
ee34099 
Also update phpstan baseline.
@mfn mfn self-assigned this Nov 6, 2021
@mfn mfn merged commit e4b9d6a into rebing:master Nov 6, 2021
@mfn mfn deleted the mfn-typehints branch November 6, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfn mfn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfn