Skip to content

[SYCL][Doc] Rephrase "recording to" #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EwanC merged 1 commit into from
Jul 12, 2023
Merged

[SYCL][Doc] Rephrase "recording to" #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Guo Yejun, Intel +
Dan Holmes, Intel +
Greg Lueck, Intel +
Steffen Larsen, Intel +
Jaime Arteaga Molina, Intel +
Ewan Crawford, Codeplay +
Ben Tracy, Codeplay +
Duncan McBain, Codeplay +
Expand All @@ -50,6 +51,7 @@ Gordon Brown, Codeplay +
Erik Tomusk, Codeplay +
Bjoern Knafla, Codeplay +
Lukas Sommer, Codeplay +
Maxime France-Pillois, Codeplay +
Ronan Keryell, AMD +

== Dependencies
Expand Down Expand Up @@ -169,13 +171,13 @@ what data is internal to the graph for optimization, and dependencies don't need
to be inferred.

It is valid to combine these two mechanisms, however it is invalid to modify
a graph using the explicit API while that graph is currently being recorded to,
for example:
a graph using the explicit API while that graph is currently recording commands
from any queue, for example:

[source, c++]
----
graph.begin_recording(queue);
graph.add(/*command group*/); // Invalid as graph is being recorded to
graph.add(/*command group*/); // Invalid as graph is recording a queue
graph.end_recording();
----

Expand Down