[SYCL][Graph] Add support for host task #344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancepillois
added
the
Graph Implementation
EwanC
reviewed
Nov 27, 2023
Collaborator
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
Looks good overall, but I need to take another look at makePartitions() to get my head around it. Here's my comments so far on mostly superficial points.
sycl/test-e2e/Graph/Inputs/interop-level-zero-get-native-mem.cpp
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Nov 27, 2023
mfrancepillois
force-pushed
the
maxime/host_task
branch
from
6d5a347 to
4e2256f
Compare
reble
reviewed
Nov 27, 2023
reble
reviewed
Nov 27, 2023
reble
reviewed
Nov 27, 2023
reble
reviewed
Nov 27, 2023
reble
reviewed
Nov 27, 2023
reble
reviewed
Nov 27, 2023
reble
reviewed
Nov 27, 2023
EwanC
approved these changes
Nov 28, 2023
Collaborator
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
LGTM apart from some more minor comments, this is a nice feature addition.
The longer form descriptive comments are very helpful too.
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/Inputs/interop-level-zero-get-native-mem.cpp
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Nov 30, 2023
EwanC
approved these changes
Nov 30, 2023
Collaborator
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
New diagrams are great, thanks ⭐
reble
reviewed
Nov 30, 2023
julianmi
approved these changes
Dec 4, 2023
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
Adds graph partitioning process to handle host task dependencies. Adds e2e tests. Updates design doc.
mfrancepillois
force-pushed
the
maxime/host_task
branch
from
eb3585f to
dc5a2b8
Compare
Collaborator
Author
|
Upstream PR : intel#12064 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds graph partitioning process to handle host task dependencies.
Adds e2e tests.
Updates design doc.