[SYCL] Remove CGF reuse in graph nodes #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
approved these changes
Mar 6, 2023
Collaborator
|
Would be good to have a test case with this PR to show if #49 was fixed. |
EwanC
reviewed
Mar 7, 2023
reble
reviewed
Mar 7, 2023
reble
reviewed
Mar 7, 2023
Collaborator
|
@reble I've rebased this after your naming convention changes and renamed the variables to use the uppercase LLVM convention |
reble
reviewed
Mar 13, 2023
- Removes use of the CGF when submitting graph nodes. - Handler info is extracted and copied into nodes - Adding nodes in record and replay moved to finalize. - Workarounds for reduction wg sizes added. - Note reductions are broken by this commit due to missing accessor support
Introduce a test case which fails before this commit and passes afterwards. Based on #49
* Comment where hardcoded defaults came from * Use `static_cast` rather than c-style cast * clang-format new test
EwanC
reviewed
Mar 17, 2023
reble
approved these changes
Mar 20, 2023
added 2 commits
March 21, 2023 09:26
Instead of USM arguments, it is buffer accessors that should be used for edge detection. Fixes `graph-explicit-node-ordering.cpp` test ordering which is currently creating incorrect extra edges Also added a test for explicit API with accessor edges, we can use to see if this logic works once accessors are better supported. * Defined macro ``TEST_GRAPH_REDUCTIONS` for use in tests with reductions to enable that codepath, otherwise it is undefined.
Make test consistent with other tests by using asserts rather than printing to std out.
This change adds a new handler constructor which takes a graph, rather than creating a default temporary queue object to pass to the existing constructor. Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
Bensuo
commented
Mar 23, 2023
Collaborator
Author
Bensuo
left a comment
Bensuo
left a comment
There was a problem hiding this comment.
LGTM just a minor typo suggestion.
Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note reductions are broken by this commit due to missing accessor support which will be addressed in a future PR.