This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Add CreationTime to elasticache replication groups
#678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to easily filter for old or expired elasticache replication groups by adding the `CreationTime` property to them. This allows `aws-nuke` to easily clear out all "old" resources while leaving recent ones intact.
rbroemeling
force-pushed
the
elasticache-created-time
branch
from
1ccc887 to
db1054e
Compare
|
If you would like me to rejig this so that the Between the options of "pulling in the entire metadata struct from AWS" and "pulling in only specific fields from the metadata struct from AWS", I think that I like pulling in only specific fields better, but I'm happy to be guided by the standard of Let me know! |
der-eismann
reviewed
Oct 29, 2021
Comment on lines
+51
to
+54
| properties := types.NewProperties() | ||
| if i.replicationGroup.ReplicationGroupCreateTime != nil { | ||
| properties.Set("CreationTime", i.replicationGroup.ReplicationGroupCreateTime.Format(time.RFC3339)) | ||
| } |
There was a problem hiding this comment.
You could also add more properties like the Group ID or tags if it has some.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to easily filter for old or expired elasticache replication groups by adding the
CreationTimeproperty to them. This allowsaws-nuketo easily clear out all "old" resources while leaving recent ones intact.Note that this functionality requires the updated
aws-sdk-golibrary version, as was PR'ed in #677.