This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Add support for additional ECR resource types via Cloud Control API #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR registers the following additional resource types via the Cloud Control API:
AWS::ECR::PublicRepository
AWS::ECR::PullThroughCacheRule
AWS::ECR::RegistryPolicy
AWS::ECR::ReplicationConfiguration
It also registers
AWS::ECR::Repository
as a duplication of the existingECRRepository
module.Testing
Using an internal AWS Account, I've created one of each type of resource and checked there they are all removed by these changes.
I would note that
AWS::ECR::PublicRepository
appears to only be available in theus-east-1
region, so if you have other regions configured (I only testedus-west-2
), you will receive an error message like this for those regions:This error is only for those regions that do not support this resource type and that resource type is successfully cleaned up from the
us-east-1
region.Discussion
I've seen the discussion elsewhere that registering each Cloud Formation namespace using
registerCloudControl()
is a temporary solution to resolve some potential conflict with existing modules. As I foresee needing to add support for many more resource types via the Cloud Control API, should I count on continuing the workflow outlines in this PR until further notice?