This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new module to handle ECS Tasks. While most ECS Tasks are handled through other dependent resources, there still exists an opportunity for an unhandled task to error out the AWS Nuke cleanup process. Details below.
Task Coverage
Testing
Tests were performed to cover both existing handled tasks and those that have been found to be unhandled.
First, a standalone Fargate task was launched within a new cluster and the existing AWS Nuke was used to clean these resources up. A failure was thrown with a message about the running task:
Then, using this new module, AWS Nuke was run again and it found the task and handled it as expected:
Setup code
The following code was used to launch a standalone Fargate task.