Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUD-3168 manually provide auth secrets to support vault #121

Merged
merged 1 commit into from
Jul 18, 2022
Merged

CLOUD-3168 manually provide auth secrets to support vault #121

merged 1 commit into from
Jul 18, 2022

Conversation

svenwltr
Copy link
Member

@svenwltr svenwltr commented Jul 18, 2022 •
edited
Loading

https://rebuyer.atlassian.net/browse/CLOUD-3168

  • Require to pass oauth credentials instead of reading them via env vars to support Vault.
  • Hardcode / as final redirect, because referrer are not working anymore for some reason.

@svenwltr svenwltr self-assigned this Jul 18, 2022
@svenwltr svenwltr force-pushed the vault-auth-middleware branch from 8351545 to 4201311 Compare July 18, 2022 10:10
@svenwltr svenwltr force-pushed the vault-auth-middleware branch from 11c78db to af4b321 Compare July 18, 2022 11:04
@svenwltr svenwltr marked this pull request as ready for review July 18, 2022 11:05
@svenwltr svenwltr requested a review from a team as a code owner July 18, 2022 11:06
@svenwltr svenwltr merged commit 69bf23a into master Jul 18, 2022
@svenwltr svenwltr deleted the vault-auth-middleware branch July 18, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@der-eismann der-eismann der-eismann approved these changes

Assignees

@svenwltr svenwltr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenwltr @der-eismann