Fixed deprecation warning in middleware.py for django 2.0 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for django 2.0
|
can this be merged, currently django debug panel does not work in django 2.0. With this fix I got it working |
|
@recamshak +1 on merge request. |
|
@Naddiseo line 11 needs to be removed for this to work I think |
merwok
reviewed
May 6, 2019
Co-Authored-By: Naddiseo <github@naddiseo.ca>
|
Please merge this! Breaks in Django 3.0. |
|
In django 3.0, the render_to_response in views.py also breaks the installation. it should be changed to render only : https://stackoverflow.com/questions/55911435/django-importerror-cannot-import-name-render-to-response-from-django-shortcu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for django 2.0
Importing from django.core.urlresolvers is deprecated in favor of django.urls.