Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CT-S651 profile #50

Merged
merged 4 commits into from
Oct 6, 2019
Merged

Add CT-S651 profile #50

merged 4 commits into from
Oct 6, 2019

Conversation

tomaski
Copy link
Contributor

@tomaski tomaski commented Feb 26, 2019

relates to #49

@mike42
Copy link
Collaborator

mike42 commented Mar 3, 2019

Thanks for submitting. The check failed because of a yamllint issue. I'm happy to merge this if you can make yamllint happy.

$ find data/ -name '*.yml' | xargs yamllint
data/profile/CT-S651.yml
  78:4      error    no new line character at the end of file  **(new-line-at-end-of-file)**

Something to be aware of, the code pages in this profile are not quite the same as those listed under ESC t (page 83) in the PDF linked at #49. This is likely to result in gibberish for some non-ASCII text.

image

@tomaski
Copy link
Contributor Author

tomaski commented Mar 3, 2019

hmm that is weird. I even previously force-pushed corrected commit with the newline at the end and it somehow still got removed. Fixed it again. Also made some adjustments to the codepages; since there is no mention of 255>n>41 - should I have those removed?
Also, there seems to be slightly adjusted codepage listing for that particular printer model on page 270

@mike42 mike42 merged commit b25550c into receipt-print-hq:master Oct 6, 2019
@mike42
Copy link
Collaborator

mike42 commented Oct 6, 2019

I've merged as-is. I'll remove the undefined code pages separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants