Allow subclassing the collection view layout #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a property called menuLayoutClass that allows you to override the PagingCollectionViewLayout class type. This means you can provide your own subclass of the layout. Since the collection view layout type will be set after the PagingViewController has been initialized we need to wait to initialize the collection view layout until the view has loaded. This means both the collectionViewLayout and the collectionView are now optional. This also means we need to update the initializer for the PagingView. It now takes the collectionView and the pageView as arguments in the configure function, which is called after the view has loaded.
Rename enum from InvalidationSummary to InvalidationState. Combine .everything and .dataSourceCounts into one case. Rename the .partial case to .nothing.
rechsteiner
force-pushed
the
layout-subclass
branch
from
c5d8f68 to
2c4b16e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a property called menuLayoutClass that allows you to override the
PagingCollectionViewLayout class type. This means you can provide your
own subclass of the layout.
Since the collection view layout type will be set after the
PagingViewController has been initialized we need to wait to initialize
the collection view layout until the view has loaded. This means both
the collectionViewLayout and the collectionView are now optional. This
also means we need to update the initializer for the PagingView. It now
takes the collectionView and the pageView as arguments in the configure
function, which is called after the view has loaded.