Fix issues with reloading data #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of reloadData was causing unexpected results and would sometimes crash the application. This happened because we were relying on the existing select method to reload data. Instead we create a separate method that makes sure to reload both the collection view and page view controller to the new state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of reloadData was causing unexpected
results and would sometimes crash the application. This happened
because we were relying on the existing select method to reload
data. Instead we create a separate method that makes sure to reload
both the collection view and page view controller to the new state.
This also fixes an issue where you could swipe in the page view
controller after reloading data with no items (a5759ba)