Fix calculation for transition distance #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the development team, remove the custom spacing indicator from the calendar example, fix the unleash example and update the labels in the storyboard example
When swiping to pages on the left or right edge we previously just took the min and max value of the content offset to make sure it didn’t move too far. This caused the transition to suddenly stop instead of smoothly transitioning to the correct place. This updated checks if the new content offset will be near any of the edges and calculate how much it will overshoot. Then we can just subtract that value from the original distance to get the correct transition.
rechsteiner
added a commit
that referenced
this pull request
Feb 20, 2017
The fix for the transition distance in #33 had an issue with selecting an item on the opposite side while being near an edge. We only want to subtract the overshoot when we’re moving towards an edge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swiping to pages on the left or right edge we previously just took
the min and max value of the content offset to make sure it didn’t move
too far. This caused the transition to suddenly stop instead of
smoothly transitioning to the correct place.
This updated checks if the new content offset will be near any of the
edges and calculate how much it will overshoot. Then we can just
subtract that value from the original distance to get the correct
transition.