Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of default paging cell #602

Conversation

ispiropoulos
Copy link
Contributor

These elements should identify as tab structure and identify as tab 1 of 4, etc. – similar to how UITabBar does it. As it stands, a screen reader user would not be informed well enough to know how to interact with this system since this information is unexposed to them.

These elements should identify as tab structure and identify as tab 1 of 4, etc. – similar to how `UITabBar` does it. As it stands, a screen reader user would not be informed well enough to know how to interact with this system since this information is unexposed to them.
@rechsteiner
Copy link
Owner

Thanks for the fix 🙌

@rechsteiner rechsteiner merged commit 060b985 into rechsteiner:master Oct 15, 2021
@ispiropoulos
Copy link
Contributor Author

Thanks for the fix 🙌

Thanks for Parchment ;)

@ispiropoulos
Copy link
Contributor Author

ispiropoulos commented Oct 15, 2021

@rechsteiner any plans on releasing a new tag & updating the podspec? There's quite some activity since Dec 2020

@rechsteiner
Copy link
Owner

Yeah, for sure. Need to do a bit of testing first, but will release a new version this weekend

@ispiropoulos
Copy link
Contributor Author

Yeah, for sure. Need to do a bit of testing first, but will release a new version this weekend

Awesome. For the time being I have subclassed PagingTitleCell and I override func setPagingItem(_ pagingItem: PagingItem, selected: Bool, options: PagingOptions) to keep the PagingItem title and selection state because viewModel is set as private. Having this change on the next release will help me do some clean up ;)

@ykws
Copy link

ykws commented Oct 15, 2021

@rechsteiner Hi, when this pull request merged, circle ci failing, so please check detail in it.

060b985

@rechsteiner
Copy link
Owner

Oh, looks like it was a compile error here. @ispiropoulos could you revert back to using viewModel?.selected?

@ispiropoulos
Copy link
Contributor Author

Oh, looks like it was a compile error here. @ispiropoulos could you revert back to using viewModel?.selected?

Eeeeeh totally my bad. Big confidence-> Stupid mistakes.

There you go

@rechsteiner
Copy link
Owner

Thanks 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants