Fix an IllegalStateException crash #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you play something, then go home on the device, and come back to something that should run popCurrentPage(), IE `noLinksFound()`, it often causes the app to crash into safe mode with IllegalStateException. This may not be the best solution here, but testing seems to indicate it does work to fix this. I thought about using `supportFragmentManager.popBackStack()`, but that seems to cause a bigger delay in doing anything, even if we don't have any issues here. Also `onBackPressedDispatcher.onBackPressed()` can be more in line with how Android handles back press actions, respecting the back stack and fragment lifecycle more conveniently so went with this approach.
|
I have no idea if this fixes the issue as it is like 1 frame timing, however I will trust you on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you play something, then go home on the device, and come back to something that should run popCurrentPage(), IE
noLinksFound(), it often causes the app to crash into safe mode with IllegalStateException.This may not be the best solution here, but testing seems to indicate it does work to fix this.
I thought about using
supportFragmentManager.popBackStack(), but that seems to cause a bigger delay in doing anything, even if we don't have any issues here. AlsoonBackPressedDispatcher.onBackPressed()can be more in line with how Android handles back press actions, respecting the back stack and fragment lifecycle more conveniently so went with this approach.