Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base_convert: Find an allocation free method. Maybe extract from the top? #294

Open
github-actions bot opened this issue Aug 13, 2023 · 0 comments
Open
Assignees
Labels
optimize Potential optimization opportunity tracker Issue tracked by bot

Comments

@github-actions
Copy link

On 2023-08-13 @prestwich wrote in 55c5411 “Merge pull request #293 from recmo/remco/base-to”:

Find an allocation free method. Maybe extract from the top?

    ///
    /// # Panics
    ///
    /// Panics if the base is less than 2.
    #[inline]
    #[cfg(feature = "alloc")] // OPT: Find an allocation free method. Maybe extract from the top?
    pub fn to_base_be(&self, base: u64) -> impl Iterator<Item = u64> {
        struct OwnedVecIterator {
            vec: alloc::vec::Vec<u64>,
        }

From src/base_convert.rs:70

@github-actions github-actions bot added optimize Potential optimization opportunity tracker Issue tracked by bot labels Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimize Potential optimization opportunity tracker Issue tracked by bot
Projects
None yet
Development

No branches or pull requests

1 participant