Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove identifierSpace and schemaSpace; make view templates mandatory #140

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

osma
Copy link
Contributor

@osma osma commented Oct 5, 2023

This PR drops the concepts of identifierSpace and schemaSpace from the spec and instead makes view templates mandatory; this was suggested by @wetneb in #139 (comment).

Arguments for the change:

  • The notions of identifierSpace and schemaSpace date from the Freebase era, as noted in the spec itself (the note is removed in this PR). Their relevance and usefulness in the current situation is at best unclear. Getting rid of cruft simplifies the spec and implementation of API services.
  • Requiring the use of a single identifierSpace makes it impossible to provide entities from a mixture of URI namespaces. Dropping identifierSpace solves the problem. In a mixed namespace setting, a view template of {+id} can be used along with using full URIs as entity identifiers.
  • View templates already provide a mechanism for turning entity identifiers into full URIs; this is more flexible than using identifierSpace. This PR makes the view templates mandatory, ensuring that entity identifiers can always be turned into URIs.
  • The definition of schemaSpace has shifted; it was last changed for spec version 0.2 in PR Adjust definition of schema space #76, but it seems that current endpoints and manifest examples use schemaSpace in different ways (some use a type such as skos:Concept, while others link to ontologies or data model documentation).

Details of changes:

  • Adjusted the spec itself
  • Adjusted the schema
  • Adjusted the examples

Closes #139

@osma
Copy link
Contributor Author

osma commented Oct 5, 2023

I'll fix the merge conflict caused by #141 tomorrow

@osma osma force-pushed the 139-remove-identifierSpace-and-schemaSpace branch from a970c58 to 0713533 Compare October 6, 2023 08:09
@osma
Copy link
Contributor Author

osma commented Oct 6, 2023

Rebased, fixed the conflict, force-pushed.

@fsteeg fsteeg merged commit 8accec5 into master Nov 9, 2023
1 check passed
@fsteeg fsteeg deleted the 139-remove-identifierSpace-and-schemaSpace branch November 9, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using identifierSpace when the entity set uses a mixture of namespaces
3 participants