Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address devtools::check() warning and note #133

Open
jamesmbaazam opened this issue May 12, 2023 · 2 comments
Open

Address devtools::check() warning and note #133

jamesmbaazam opened this issue May 12, 2023 · 2 comments

Comments

@jamesmbaazam
Copy link
Contributor

When you run devtools::check(), you get the following warning and note that should probably be addressed:

❯ checking S3 generic/method consistency ... WARNING
  as.igraph:
    function(x, ...)
  as.igraph.epicontacts:
    function(x)
  See section ‘Generic functions and methods’ in the ‘Writing R
  Extensions’ manual.

❯ checking dependencies in R code ... NOTE
  Namespace in Imports field not imported from: ‘colorspace’
    All declared Imports should be used.
  • The first is because the as.igraph.epicontacts() is missing a ... like in its generic.

  • For the second, it appears colorspace is declared as an import but not used anywhere.

  • There is also a requirement for Encoding: UTF-8 in DESCRIPTION.

I will submit a PR to address these issues.

@finlaycampbell
Copy link
Collaborator

Thanks for picking up on this! The as.igraph.epicontacts check warning should have been addressed here (ecd721e), so I'm not sure why you're still seeing it...

@jamesmbaazam
Copy link
Contributor Author

Strange. Is it probably a devtools bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants