-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added nosocomial death analysis section #26
base: master
Are you sure you want to change the base?
Conversation
Thanks for this. The report is currently failing for me: /// compiling report: 'temporal_trends_2019-10-17'
processing file: temporal_trends_2019-10-17.Rmd
|. | 2%
inline R code fragments
|.. | 4%
label: setup (with options)
List of 1
$ include: logi FALSE
|.... | 5%
ordinary text without R code
|..... | 7%
label: read_scripts
Global cleaning rules have been imported from:
'dictionary/cleaning_rules.xlsx'
and stored into: 'cleaning_rules'.
You can use these to clean data with linelist's function:
'clean_data(... , wordlists = cleaning_rules)'.
|...... | 9%
ordinary text without R code
|....... | 11%
label: load_data
|........ | 13%
inline R code fragments
|......... | 15%
label: add_top_zones
|........... | 16%
ordinary text without R code
|............ | 18%
label: filter
|............. | 20%
ordinary text without R code
|.............. | 22%
label: custom_colors
|............... | 24%
ordinary text without R code
|................. | 25%
label: contacts_overall
|.................. | 27%
ordinary text without R code
|................... | 29%
label: contacts_sub_coordination
Quitting from lines 347-437 (temporal_trends_2019-10-17.Rmd)
Error: Column `month_report` is unknown
In addition: Warning messages:
1: New theme missing the following elements: axis.ticks.length.x, axis.ticks.length.x.top, axis.ticks.length.x.bottom, axis.ticks.length.y, axis.ticks.length.y.left, axis.ticks.length.y.right
2: a tie among values (butembo, katwa, kayna, kyondo) was broken by choosing the first value |
likewise I've submitted a new pull request with Aminata's updates to this report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, sorry for a fast review:
- I can confirm the new version compiles fine with the current data (Tues 17 Dec 2019) and looks fine (beautiful!) on my laptop
- new code looks good
- one caveat to check out (not necessarily wrong per say, but need checking): the denominator for the proportions is sometimes the whole dataset, sometimes the number of non-missing observations
count(place_death_crude) %>% | ||
spread(place_death_crude, n, fill = 0, drop = FALSE) %>% | ||
mutate(total = nrow(x), # avoid adorn_totals | ||
denom = total - unknown, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: the denominator here excludes unknown place of death; this is not the case later
nosocomial_deaths_overall_time <- x %>% | ||
count(epiweek_report_label, place_death_crude) %>% | ||
spread(place_death_crude, n, fill = 0, drop = FALSE) %>% | ||
adorn_totals(c("col"), name = "total") %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here the denominator is the total
nosocomial_deaths_sub_coordination <- x %>% | ||
count(sous_coordination, place_death_crude) %>% | ||
spread(place_death_crude, n, fill = 0, drop = FALSE) %>% | ||
adorn_totals("col", name = "total") %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above: denominator is the total
count(top_zones, place_death_crude) %>% | ||
spread(place_death_crude, n, fill = 0, drop = FALSE) %>% | ||
adorn_totals("col", name = "total") %>% | ||
mutate(denom = total, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above, denominator is the total (including unknown)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing review request from history.
I added nosocomial death analysis section with the new MLL community_hcf designation.